fix: mark database drivers as optional peer dependencies #12484
Merged
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
When using yarn 2 and PnP, it will throw an error because sequelize is trying to access the database drivers without listing them as direct dependencies/peerDependencies in package.json
(node:13140) [MODULE_NOT_FOUND] Error: sequelize tried to access mysql2, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Since we don't want to list them as direct dependencies, we can fix this error by listing all the database drivers as optional peer dependencies using the new
peerDependenciesMeta
field.