fix(sqlite): quote table names in sqlite getForeignKeysQuery #12752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table names were not quoted in
getForeignKeysQuery
that was called byqueryInterface.describeTable
for thesqlite
dialect.I discovered this defect when I had a sqlite table named "Order" while working on
sequelize-auto
This PR fixes it, using the same
quoteTable
function used elsewhere.Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
In dialects/sqlite/query-generator.ts, fix
getForeignKeysQuery
so that it quotes the table names in the same manner that is done in other methods.Before:
After: