Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for multi composite key to V5 branch #12800

Closed
wants to merge 6 commits into from
Closed

Conversation

cskiwi
Copy link

@cskiwi cskiwi commented Oct 31, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added the fix from #11984 to the v5 branch.
This is needed for people using 'sequelize-typescript' because that doesn't work on v6 yet

@hsource
Copy link
Contributor

hsource commented Nov 18, 2020

It looks like sequelize-typescript will support v6 (see sequelize/sequelize-typescript#807), including v6.2+ hopefully soon!

@papb
Copy link
Member

papb commented Jan 19, 2021

Hello @cskiwi! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Sorry to take long to reply. I shall be replying faster now.

Some tests are failing, can you fix them?

@papb papb added the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Jan 19, 2021
@cskiwi
Copy link
Author

cskiwi commented Jan 20, 2021

hi @papb I would really love to run the tests, but I get following error:

> cross-env DIALECT=postgres npm run test-integration


> sequelize@0.0.0-development test-integration D:\Programming\Code\cskiwi\sequelize
> mocha --require scripts/mocha-bootload --globals setImmediate,clearImmediate --exit --check-leaks --colors -t 30000 --reporter spec "test/integration/**/*.test.js"

FIXME: I want to be supported in this dialect as well :-(


  [POSTGRES] Alias
    1) "before each" hook for "should uppercase the first letter in alias getter, but not in eager loading"


  0 passing (30s)
  1 failing

  1) "before each" hook for "should uppercase the first letter in alias getter, but not in eager loading":
     Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:551:17)
      at processTimers (internal/timers.js:494:7)



npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! sequelize@0.0.0-development test-integration: `mocha --require scripts/mocha-bootload --globals setImmediate,clearImmediate --exit --check-leaks --colors -t 30000 --reporter spec "test/integration/**/*.test.js"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the sequelize@0.0.0-development test-integration script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\glenn\AppData\Roaming\npm-cache\_logs\2021-01-20T08_30_11_756Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! sequelize@0.0.0-development test-integration-postgres: `cross-env DIALECT=postgres npm run test-integration`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the sequelize@0.0.0-development test-integration-postgres script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\glenn\AppData\Roaming\npm-cache\_logs\2021-01-20T08_30_11_804Z-debug.log

Any suggestions?

@github-actions github-actions bot added the stale label Oct 28, 2021
@github-actions github-actions bot closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants