fix(pg connection-manager.js): add query_timeout to dialogOptions
#13476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has existed in pg since v7.7 - see discussion at brianc/node-postgres#1760 Adding to properties to be passed to new connection config so it can be used with sequelize
2ns2os
changed the title
query_timeout to dialogOptions
missed comma
wbourne0
added
dialect: postgres
wbourne0
approved these changes
Oct 10, 2021
Comment on lines
+118
to
+119
| // Client side request timeout in milliseconds. Added in pg v7.7 | ||
| 'query_timeout', |
There was a problem hiding this comment.
Took me a moment to realize this isn't a sequelize option, its an option pg. Can you add a link to the docs for clarification? Thanks.
There was a problem hiding this comment.
I think the majority if not all of those dialectOptions are related to the postgres client (there is a comment at the very top of that code block)
sdepold
added
the
status: awaiting response
|
Same as #13258 ? |
github-actions
bot
removed
the
status: awaiting response
|
going to close this one since the other PR has a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
The
query_timeoutoption has existed in pg since v7.7 - see discussion at brianc/node-postgres#1760This change adds it to properties to be passed to new connection config so it can be used with sequelize