Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: redirect engines.md to our website #14380

Merged
merged 2 commits into from
Apr 13, 2022
Merged

docs: redirect engines.md to our website #14380

merged 2 commits into from
Apr 13, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Apr 13, 2022

This PR removes the Supported Database table from ENGINE.md, redirecting the user to https://sequelize.org/releases/ instead, to deduplicate the information that we have to maintain :)

@WikiRik
Copy link
Member

WikiRik commented Apr 13, 2022

Do we need this file? It was added in #12168 without a real reason imo.

It might be better to refer to the Releases page from the README and then we should also be fine

@ephys
Copy link
Member Author

ephys commented Apr 13, 2022

I kept it in case someone referenced to it, but it's not worth cluttering our main repo to avoid breaking a link.
I'll remove it and update the readme

@ephys ephys requested a review from WikiRik April 13, 2022 12:38
@ephys ephys merged commit 708106a into main Apr 13, 2022
@ephys ephys deleted the ephys-patch-1 branch April 13, 2022 12:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

vanthome pushed a commit to vanthome/sequelize that referenced this pull request Jun 12, 2022
Hornwitser added a commit to Hornwitser/sequelize that referenced this pull request Aug 29, 2023
Missed when ENGINE.md was removed in in sequelize#14380.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants