New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test v7 against node 18 #14415
ci: test v7 against node 18 #14415
Conversation
Can we wait until 2022-10-25 with this so Node 18 has had its first LTS release? |
We're going to need to wait a little bit more, until |
Should we? I can understand waiting until it reaches LTS before upgrading an app, but I think a library should be ready before then |
We skipped Node 17 as well and currently Node 18 is in the same state. I agree that we should be ready to support it when the first LTS release is out, but don't think replacing Node 16 with this is the way to go at this moment. Maybe we can add the latest version as a third version to test? |
We skipped node 17 because we didn't plan on supporting it at all, as the release is only maintained for 6 months.
We can, but this would increase our CI time to ~22 minutes, from ~15 minutes currently. |
I have a feeling we'll get a new release from that later today. |
Okay, after the update of Just for now, you could just add |
Another update, it looks like |
Linting fails, see lo1tuma/eslint-plugin-mocha#325 for context |
Let's wait until TypeStrong/typedoc#1935 is solved and then we should be good to merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, just need to update it in the repo settings.
Wooh 🥳 |
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
🎉 This PR is included in version 7.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description Of Change
This PR replaces node 16 with node 18 in our CI, so that we test against both our minimum and maximum supported node versions