Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test v7 against node 18 #14415

Merged
merged 7 commits into from May 30, 2022
Merged

ci: test v7 against node 18 #14415

merged 7 commits into from May 30, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Apr 20, 2022

Description Of Change

This PR replaces node 16 with node 18 in our CI, so that we test against both our minimum and maximum supported node versions

@WikiRik
Copy link
Member

WikiRik commented Apr 20, 2022

Can we wait until 2022-10-25 with this so Node 18 has had its first LTS release?

@ephys
Copy link
Member Author

ephys commented Apr 20, 2022

We're going to need to wait a little bit more, until eslint-plugin-jsdoc supports node 18

@ephys
Copy link
Member Author

ephys commented Apr 20, 2022

Can we wait until 2022-10-25 with this so Node 18 has had its first LTS release?

Should we? I can understand waiting until it reaches LTS before upgrading an app, but I think a library should be ready before then

@WikiRik
Copy link
Member

WikiRik commented Apr 20, 2022

We skipped Node 17 as well and currently Node 18 is in the same state. I agree that we should be ready to support it when the first LTS release is out, but don't think replacing Node 16 with this is the way to go at this moment. Maybe we can add the latest version as a third version to test?
Or we wait a bit until I finally have written down my ideas for a more comprehensive test suite that runs once a week (up for debate) and focusses on more combinations of Node versions, database connector versions and database versions.

@ephys
Copy link
Member Author

ephys commented Apr 20, 2022

We skipped node 17 because we didn't plan on supporting it at all, as the release is only maintained for 6 months.
There is no real difference in stability between node 18 current and node 18 LTS, if we want to support it we should start today instead of when it gets promoted to LTS

Maybe we can add the latest version as a third version to test?

We can, but this would increase our CI time to ~22 minutes, from ~15 minutes currently.

@WikiRik
Copy link
Member

WikiRik commented Apr 20, 2022

We're going to need to wait a little bit more, until eslint-plugin-jsdoc supports node 18

I have a feeling we'll get a new release from that later today.

@WikiRik
Copy link
Member

WikiRik commented Apr 20, 2022

Okay, after the update of eslint-plugin-jsdoc we still have @azure/msal-node left (through tedious -> @azure/identity). PR is open for that, afterwards we should be able to install dependencies without adding --ignore-engines

Just for now, you could just add --ignore-engines so we can at least make sure that tests pass.

@WikiRik
Copy link
Member

WikiRik commented Apr 20, 2022

Another update, it looks like @azure/msal-node will get a regular update in about 2 weeks which will most likely include the support for Node 18.

@WikiRik WikiRik marked this pull request as draft April 21, 2022 15:26
@WikiRik WikiRik mentioned this pull request May 3, 2022
6 tasks
@WikiRik
Copy link
Member

WikiRik commented May 3, 2022

Linting fails, see lo1tuma/eslint-plugin-mocha#325 for context

@WikiRik
Copy link
Member

WikiRik commented May 28, 2022

Let's wait until TypeStrong/typedoc#1935 is solved and then we should be good to merge this

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, just need to update it in the repo settings.

@WikiRik WikiRik marked this pull request as ready for review May 30, 2022 19:50
@ephys
Copy link
Member Author

ephys commented May 30, 2022

Wooh 🥳

@ephys ephys merged commit ef4e573 into main May 30, 2022
@ephys ephys deleted the ephys/node-18 branch May 30, 2022 20:24
rharriso pushed a commit to rharriso/sequelize that referenced this pull request Jun 3, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
vanthome pushed a commit to vanthome/sequelize that referenced this pull request Jun 12, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
evanrittenhouse pushed a commit to evanrittenhouse/sequelize that referenced this pull request Jun 13, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants