Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(postgres): add support for lock_timeout #15347

Merged
merged 2 commits into from Nov 29, 2022
Merged

feat(postgres): add support for lock_timeout #15347

merged 2 commits into from Nov 29, 2022

Conversation

suonto
Copy link
Contributor

@suonto suonto commented Nov 28, 2022 •
edited

please see #15345.

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Closes #15345

WikiRik
WikiRik reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, the rest looks good to me

src/dialects/postgres/connection-manager.ts Outdated Show resolved Hide resolved
@WikiRik
Copy link
Member

WikiRik commented Nov 28, 2022

And before I forget; when we merge this it will end up in the next v7 alpha. If you want it to be included in the next v6 release you will have to open a new PR towards the v6 branch.

@WikiRik WikiRik changed the title feat(postgres): add support for lock_timeout [#15345] feat(postgres): add support for lock_timeout Nov 29, 2022
@WikiRik WikiRik merged commit 5e7cbe6 into sequelize:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres support lock_timeout
3 participants
@suonto @WikiRik @wsuonto