Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres): add support for lock_timeout #15355

Merged
merged 1 commit into from Nov 29, 2022
Merged

Conversation

suonto
Copy link
Contributor

@suonto suonto commented Nov 29, 2022

please see #15345.

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Please see linked issue.

Todos

@WikiRik WikiRik changed the title feat(postgres): add support for lock_timeout [#15345] feat(postgres): add support for lock_timeout Nov 29, 2022
@suonto
Copy link
Contributor Author

suonto commented Nov 29, 2022

@WikiRik this actually won't work because in v6 pg is still at 8.7.1. Do you think it's acceptable to upg pg for version 6 as well?

@WikiRik
Copy link
Member

WikiRik commented Nov 29, 2022

I think since we're not specifying it in the tests it should not fail. Users can install a newer version of pg to use this, the pg version is not managed by us since it's a peerDependency.

@WikiRik WikiRik merged commit 94beace into sequelize:v6 Nov 29, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants