Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oracle): For Raw queries avoid converting the input parameters passed #16067

Merged
merged 9 commits into from Jun 1, 2023
Merged

fix(oracle): For Raw queries avoid converting the input parameters passed #16067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a1ee93
fix: for Raw queries avoid converting the input parameters passed
sudarshan12s May 24, 2023
6ad5c54
fix: for Raw queries avoid converting the input parameters passed (#18)
sudarshan12s May 25, 2023
0495f19
fix: modify testcase to repeat bind names for 3 times
sudarshan12s May 26, 2023
8c668e2
fix: modify the order of bindnames in test case
sudarshan12s May 26, 2023
aee524f
fix: space missing
sudarshan12s May 26, 2023
931fc1e
fix: modify testcase to repeat bind names for 3 times (#19)
sudarshan12s May 26, 2023
af6d70f
Merge branch 'testcaseforbind' into v6
sudarshan12s May 26, 2023
fd9c7d6
Merge branch 'v6' of github.com:sudarshan12s/sequelize into v6
sudarshan12s May 26, 2023
4cf2bb5
Merge branch 'v6' of github.com:sudarshan12s/sequelize into RawqueryP…
sudarshan12s May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dialects/oracle/query.js
View file
Open in desktop
Expand Up @@ -121,6 +121,8 @@ export class OracleQuery extends AbstractQuery {
bindDef.push(...Object.values(this.options.inbindAttributes));
bindDef.push(...outParameters);
this.bindParameters = parameters;
} else if (this.isRawQuery()) {
this.bindParameters = parameters;
} else {
Object.values(parameters).forEach(value => {
bindParameters.push(value);
Expand Down
4 changes: 2 additions & 2 deletions test/integration/sequelize/query.test.js
View file
Open in desktop
Expand Up @@ -713,8 +713,8 @@ describe(Support.getTestDialectTeaser('Sequelize'), () => {
it('binds named parameters with the passed object using the same key twice', async function() {
const typeCast = dialect === 'postgres' ? '::int' : '';
let logSql;
const result = await this.sequelize.query(`select $one${typeCast} as foo, $two${typeCast} as bar, $one${typeCast} as baz${Support.addDualInSelect()}`, { raw: true, bind: { one: 1, two: 2 }, logging(s) { logSql = s; } });
const expected = dialect !== 'oracle' ? [{ foo: 1, bar: 2, baz: 1 }] : [{ FOO: 1, BAR: 2, BAZ: 1 }];
const result = await this.sequelize.query(`select $one${typeCast} as foo, $one${typeCast} as bar, $two${typeCast} as baz${Support.addDualInSelect()}`, { raw: true, bind: { one: 1, two: 2 }, logging(s) { logSql = s; } });
const expected = dialect !== 'oracle' ? [{ foo: 1, bar: 1, baz: 2 }] : [{ FOO: 1, BAR: 1, BAZ: 2 }];
expect(result[0]).to.deep.equal(expected);
if (dialect === 'postgres') {
expect(logSql).to.include('$1');
Expand Down