Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self referencing with through table where-clause clashes with the included models #16761

Closed
wants to merge 1 commit into from

Conversation

shawara
Copy link

@shawara shawara commented Nov 15, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Fix self-reference with though table where-clause in include not working correctly because top parent name in the where-clause clashes with the included models.
Closes #16719

@WikiRik
Copy link
Member

WikiRik commented Nov 15, 2023

Thanks for opening the PR! Could you add one or more tests that fail without your change but pass now?

@shawara
Copy link
Author

shawara commented Nov 16, 2023

@WikiRik I will close this PR and Open a new PR #16768 against the v6 which has the issue

@shawara shawara closed this Nov 16, 2023
@shawara shawara deleted the fix/self-ref-with-through branch February 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self referencing with through table not working correctly.
2 participants