fix: throw when using upsert in ibmi or snowflake #17155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
reviewed
Mar 10, 2024
WikiRik
approved these changes
Mar 10, 2024
ephys
changed the title
ephys
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of Changes
This PR separates a change required for PR #16988.
The IBMi and Snowflake dialects do not have valid upsert implementations and would have resulted in database errors due to the current method using unsupported syntax.
This PR removes the unused/invalid code and throws an error is the method is used.
In a future PR, both dialects should have the merge query implemented similar to what DB2 and MS SQL have.
List of Breaking Changes
Snowflake does not support upsert queries.