Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make BaseSqlExpression a unique class #17158

Merged
merged 4 commits into from
Apr 12, 2024
Merged

fix: make BaseSqlExpression a unique class #17158

merged 4 commits into from
Apr 12, 2024

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

This PR is split from #17063 and makes BaseSqlExpression and its extended classes unique.
This is required to be able to set options to restrict its values to BaseSqlExpression's.

List of Breaking Changes

BaseSqlExpression is now a unique class.

@lohart13 lohart13 requested a review from a team as a code owner March 11, 2024 00:09
@lohart13 lohart13 requested review from ephys and WikiRik March 11, 2024 00:09
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch from e474df3 to d79d9b7 Compare March 19, 2024 22:14
@WikiRik WikiRik mentioned this pull request Mar 22, 2024
Open
5 tasks
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch 4 times, most recently from 68d9a2a to 3a8b427 Compare March 27, 2024 21:59
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch from 3a8b427 to fee81fd Compare March 30, 2024 01:53
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch from fee81fd to 4266c20 Compare March 31, 2024 06:49
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch from 4266c20 to 4527243 Compare April 9, 2024 22:37
@lohart13 lohart13 force-pushed the make-basesqlexpression-unique branch from 4527243 to 32f2c6e Compare April 11, 2024 23:37
@ephys ephys changed the title fix: make BaseSqlExpression a unique class fix: make BaseSqlExpression a unique class Apr 12, 2024
@ephys ephys enabled auto-merge (squash) April 12, 2024 00:11
@ephys ephys merged commit 6a5ea6c into sequelize:main Apr 12, 2024
51 of 52 checks passed
@lohart13 lohart13 deleted the make-basesqlexpression-unique branch April 12, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lohart13 @ephys @WikiRik