-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing createRoles association method for HasMany relationship #17163
Open
sakupan102
wants to merge
6
commits into
sequelize:main
Choose a base branch
from
sakupan102:feature/create-multiple
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9726fdf
feat: add new function to create multiple instances
sakupan102 e11b19b
feat: add createMultiple method to mixinMethods
sakupan102 bb0b5be
feat: add "createRoles" key to accessors
sakupan102 7e17ccf
feat(types): add createMultiple to MultiAssociationAccessors type
sakupan102 0543e5b
feat: add "createRoles" key to accessors in belongsTo
sakupan102 8cf3c3b
fix: format
sakupan102 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to add the |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,6 +160,7 @@ export class HasManyAssociation< | |
addMultiple: `add${plural}`, | ||
add: `add${singular}`, | ||
create: `create${singular}`, | ||
createMultiple: `create${plural}`, | ||
remove: `remove${singular}`, | ||
removeMultiple: `remove${plural}`, | ||
hasSingle: `has${singular}`, | ||
|
@@ -228,12 +229,14 @@ export class HasManyAssociation< | |
'remove', | ||
'removeMultiple', | ||
'create', | ||
'createMultiple', | ||
], | ||
{ | ||
hasSingle: 'has', | ||
hasAll: 'has', | ||
addMultiple: 'add', | ||
removeMultiple: 'remove', | ||
createMultiple: 'createMultiple', | ||
}, | ||
); | ||
} | ||
|
@@ -605,6 +608,50 @@ export class HasManyAssociation< | |
options, | ||
); | ||
} | ||
|
||
/** | ||
* Create a new instances of the associated model and associate it with this. | ||
* | ||
* @param sourceInstance source instance | ||
* @param values values for target model instance | ||
* @param options Options passed to `target.bulkCreate` | ||
*/ | ||
async createMultiple( | ||
sourceInstance: S, | ||
values: AllowIterable<CreationAttributes<T>>, | ||
options: | ||
| HasManyCreateAssociationMixinOptions<T> | ||
| HasManyCreateAssociationMixinOptions<T>['fields'] = {}, | ||
): Promise<T[]> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of copying the code, |
||
if (Array.isArray(options)) { | ||
options = { | ||
fields: options, | ||
}; | ||
} | ||
|
||
if (this.scope) { | ||
for (const attribute of Object.keys(this.scope)) { | ||
// @ts-expect-error -- TODO: fix the typing of {@link AssociationScope} | ||
for (const value of values) { | ||
value[attribute] = this.scope[attribute]; | ||
} | ||
|
||
if (options.fields) { | ||
options.fields.push(attribute); | ||
} | ||
} | ||
} | ||
|
||
if (options.fields) { | ||
options.fields.push(this.foreignKey); | ||
} | ||
|
||
for (const value of values) { | ||
value[this.foreignKey] = sourceInstance.get(this.sourceKey); | ||
} | ||
|
||
return this.target.bulkCreate(values as ReadonlyArray<CreationAttributes<T>>, options); | ||
} | ||
} | ||
|
||
// workaround https://github.com/evanw/esbuild/issues/1260 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should be done in the same PR, as it now declares it as being available