Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mssql)!: move mssql to the @sequelize/mssql package #17206

Merged
merged 7 commits into from
Mar 26, 2024
Merged

feat(mssql)!: move mssql to the @sequelize/mssql package #17206

merged 7 commits into from
Mar 26, 2024

Conversation

lohart13
Copy link
Contributor

Goal of the PR

Related issue: #13722
Related PR: #17190

This PR moves the MsSql Dialect to the @sequelize/mssql package.

Relevant impacts

  • This package pre-installs the necessary mssql-specific dependency mssql. Users won't need to install the additional packages anymore. This gives us control over which version we support.
  • Unlike the postgres package, this package does not have unit tests yet. Once we add those, the script should be added to the package package.json and CI.

Other changes

Breaking changes

  • Instead of installing mssql users need to install @sequelize/mssql.

@lohart13 lohart13 marked this pull request as ready for review March 26, 2024 03:54
@lohart13 lohart13 requested a review from a team as a code owner March 26, 2024 03:54
@lohart13 lohart13 requested review from ephys and WikiRik March 26, 2024 03:54
@lohart13 lohart13 changed the title feat(mssql)!: move mssql to the @sequelize/mssql package feat(mssql)!: move mssql to the @sequelize/mssql package Mar 26, 2024
@ephys ephys mentioned this pull request Mar 26, 2024
Open
WikiRik
WikiRik approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion is optional

packages/mssql/package.json Outdated Show resolved Hide resolved
@ephys ephys enabled auto-merge (squash) March 26, 2024 22:57
@ephys ephys merged commit 8631f5a into sequelize:main Mar 26, 2024
49 of 50 checks passed
@lohart13 lohart13 deleted the split-mssql branch March 26, 2024 23:25
@lohart13 lohart13 mentioned this pull request Mar 26, 2024
Merged
@ephys ephys mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lohart13 @ephys @WikiRik