Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): explain how to use migrations #8319

Merged
merged 7 commits into from Sep 18, 2017
Merged

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Sep 16, 2017

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Current docs are really old and dont actually explain how you can create a project that use migrations. This is an attempt to improve overall documentation around migrations.

I will add more docs in this PR, so consider this as work in progress

Target issues

@mention-bot
Copy link

@sushantdhiman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @janmeier, @treythomas123 and @felixfbecker to be potential reviewers.

@codecov
Copy link

codecov bot commented Sep 16, 2017

Codecov Report

Merging #8319 into master will not change coverage.
The diff coverage is n/a.

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! :)

Copy link
Member

@janmeier janmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Ping me when it's ready for a final review

@sushantdhiman
Copy link
Contributor Author

@janmeier Its ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants