meta: update to babel 7 #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it's worth it to use babel VS rewriting in TS and using TSC? |
|
I just used babel since it was already using that but using tsc should also be fine. I think however that the question does remain; do we want to keep supporting old browsers and old Node versions or keep the same version support as sequelize v7? |
|
The same as sequelize, we don't need to support dead versions of node (and it should be fine for browsers, users always have the option to transpile the library if they need to support old browsers) |
|
Then I'll use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change any functionality, but I haven't tested the built code on the browser or with a low Node version. Therefore it's still in draft.
This brings us to the question of supported versions. The original has browser support and test on Node 10, although I think it has support for versions below that. What versions do we want to support? Just go with Node
^14.17.0 || >=16.0.0like for sequelize or do we want to keep the support for browser/old Node versions? With babel this should not be too difficult I think, but we'll have to add CI for it. @ephys any preference?