Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement for std::num::NonZero* on Rust 1.28+ #1278

Merged
merged 1 commit into from May 24, 2018
Merged

Implement for std::num::NonZero* on Rust 1.28+ #1278

merged 1 commit into from May 24, 2018

Conversation

SimonSapin
Copy link
Contributor

… regardless of the unstable feature. Fix #1274.

dtolnay
dtolnay reviewed May 24, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now that these impls are stable I would go a step further and remove them from the "unstable" feature. Please make them #[cfg(num_nonzero)].

@SimonSapin
Implement for std::num::NonZero* on Rust 1.28+
defd885 
… regardless of the `unstable` feature. Fix serde-rs#1274.
@SimonSapin
Copy link
Contributor Author

Done.

@dtolnay dtolnay merged commit 039ebc6 into serde-rs:master May 24, 2018
SimonSapin added a commit to servo/webrender that referenced this pull request May 24, 2018
@SimonSapin
Update serde to 1.0.58 + serde-rs/serde#1278
7966184
@SimonSapin SimonSapin mentioned this pull request May 24, 2018
Merged
bors-servo pushed a commit to servo/webrender that referenced this pull request May 25, 2018
Auto merge of #2777 - servo:serdeup, r=Gankro
60f4177 
Update serde to 1.0.58 + serde-rs/serde#1278

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2777)
<!-- Reviewable:end -->
@SimonSapin SimonSapin deleted the stable-nonzero branch May 25, 2018 13:05
@dtolnay dtolnay mentioned this pull request May 26, 2018
Open
6 tasks
@hcpl hcpl mentioned this pull request Sep 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonSapin @dtolnay