Update serde to 1.0.58 + serde-rs/serde#1278 #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro |
|
I thought we weren't supposed to update serde due to some knock on dependency effects? Was that resolved? |
|
@gankro The problem was depending to the latest serde_derive which depends on syn 0.14. (Not that it really matters now that we finally removed syn 0.11 (:tada:) from the dependency tree, but having three versions was a bit much) |
|
serde-rs/serde#1278 and servo/deserialize_from_enums7 are based on 1.0.58 rather than .59 or upstream/master to avoid picking up syn 0.14 yet. |
|
@bors-servo r+ |
|
📌 Commit 7966184 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 25, 2018
Update serde to 1.0.58 + serde-rs/serde#1278 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2777) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is