Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): for serverless-trace, don't copy when source and… #760

Merged
merged 2 commits into from Nov 3, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 3, 2020

… destination are the same.

Should fix: #461

Not sure why but somehow nodeFileTrace may be resolving the wrong files for certain project structure, so when copying if destination and source are the same, the fse.copy promise will fail and hence fail the build. Though still not completely unsure why, this at least avoids the error and allows the build to continue, which is a better developer experience.

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #760 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   79.70%   79.66%   -0.04%     
==========================================
  Files          55       55              
  Lines        1808     1810       +2     
  Branches      394      395       +1     
==========================================
+ Hits         1441     1442       +1     
- Misses        309      310       +1     
  Partials       58       58              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 93.33% <66.66%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b586f46...50a3ce3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Source and destination must not be the same. When using useServerlessTraceTarget
1 participant