Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outputs schema #507

Merged
merged 2 commits into from Oct 13, 2020
Merged

Fix outputs schema #507

merged 2 commits into from Oct 13, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 12, 2020

Fixes #506

After serverless/serverless#8319 in some schema scenarios primitives got converted to arrays, and that happened for outputs

This patch ensures it's not the case.

Additionally it fixes the issue of too restrictive outputs name schema. It followed restrictions on AWS side, while on our side there are no name restrictions

@medikoo medikoo added the bug Something isn't working label Oct 12, 2020
@medikoo medikoo self-assigned this Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #507 into master will increase coverage by 9.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   48.58%   58.14%   +9.56%     
==========================================
  Files          89       67      -22     
  Lines        2822     2143     -679     
==========================================
- Hits         1371     1246     -125     
+ Misses       1451      897     -554     
Impacted Files Coverage Δ
lib/plugin.js 87.50% <ø> (ø)
test/index.js
src/lib/transaction.js
.../lib/eventDetection/eventTypes/customAuthorizer.js
src/lib/eventDetection/eventTypes/apiGateway.js
src/lib/eventDetection/eventTypes/sns.js
src/lib/frameworks/index.js
src/lib/spanHooks/hookHttp.js
src/lib/frameworks/wrappers/lambda-api.js
src/lib/eventDetection/eventTypes/kinesis.js
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a2abb...43928ea. Read the comment docs.

@medikoo medikoo merged commit 689e9b2 into master Oct 13, 2020
@medikoo medikoo deleted the 1012-fix-outputs-schema branch October 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration error when using custom variables in outputs section
1 participant