Add getDashboardInteractUrl util
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
force-pushed
the
fix-formatting-for-dashboard-set-org-step
branch
2 times, most recently
from
bac5620
to
d1c3a38
Compare
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 48.28% 48.28%
=======================================
Files 87 87
Lines 2802 2806 +4
=======================================
+ Hits 1353 1355 +2
- Misses 1449 1451 +2
Continue to review full report at Codecov.
|
medikoo
reviewed
Jun 7, 2021
lib/dashboard.js
Outdated
| module.exports.getDashboardUrl = getDashboardUrl; | ||
|
|
||
| module.exports.getDashboardInteractUrl = (ctx) => { | ||
| if (!ctx.sls.enterpriseEnabled) return dashboardUrl; |
There was a problem hiding this comment.
Wouldn't it be more logical to return null in this case?
pgrzesik
force-pushed
the
fix-formatting-for-dashboard-set-org-step
branch
from
d1c3a38
to
e1fbe09
Compare
medikoo
reviewed
Jun 7, 2021
| @@ -342,7 +343,9 @@ describe('lib/cli/interactive-setup/dashboard-set-org.test.js', function () { | |||
| expect(context.configuration.org).to.equal('testinteractivecli'); | |||
| expect(context.configuration.app).to.equal('other-app'); | |||
| expect(stdoutData).to.include( | |||
| 'Your project has been setup with org: "testinteractivecli" and app: "other-app"' | |||
| `${chalk.green('Your project has been setup with org: ')}${chalk.white.bold( | |||
There was a problem hiding this comment.
It would be safer to use strip-ansi in such case (we already do it in some places), as otherwise if we run tests in environement which does not support colors those tests will fail.
There was a problem hiding this comment.
That's a great suggestion 👍
pgrzesik
force-pushed
the
fix-formatting-for-dashboard-set-org-step
branch
from
e1fbe09
to
23809b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getDashboardInteractUrlutil + improves formatting of success message indashboard-set-orgstep of Onboarding CLIAddresses: serverless/serverless#9367
Related to: serverless/serverless#9536