Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove VSCode project-level settings #251

Closed
wants to merge 1 commit into from

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 19, 2019

I believe specific editor settings should not be committed into project.

In my case those settings collide with how I work with VS Code. I have some global settings, which I need to tweak in context of this project, still that's not possible without editing this file (as that in turn affects git status, which makes working with project repository cumbersome).

@coveralls
Copy link

coveralls commented Aug 19, 2019

Coverage Status

Coverage remained the same at 84.697% when pulling d664148 on medikoo/remove-vscode-settings into 660f8b7 on dev.

@medikoo medikoo closed this Aug 19, 2019
@medikoo medikoo reopened this Aug 19, 2019
@medikoo medikoo force-pushed the medikoo/remove-vscode-settings branch from ac7dae0 to d664148 Compare August 19, 2019 14:40
@medikoo medikoo added the v1 issues found on v1.x or feature requests label Aug 19, 2019
@wbreza
Copy link
Member

wbreza commented Aug 26, 2019

@medikoo - Shouldn't your global configuration settings live in a user profile configuration outside of the project's settings.json?

From what we have experienced if you remove these settings you will not get an optimal developer experience since the linting rules will not be applied by VS Code while editing files.

@medikoo
Copy link
Contributor Author

medikoo commented Aug 27, 2019

@medikoo - Shouldn't your global configuration settings live in a user profile configuration outside of the project's settings.json?

They are there, but I have a need to fine tune few of those settings for this project specifically, and that can't be done reliably with current setup.

e.g. in global settings I have set that I want to run formatting on save in case of all projects (In 99% of them it's desirable, and I don't want to apply these settings per project, that'll be cumbersome).

While in case of this project it introduces extra whitespace changes I don't want to have, therefore I want to keep it off here - and I can't do it without updating .vscode/settings.json (btw. I keep that file globally ignored in git, so it never ends committed to any repository)

I think the source of a problem here is, that ESLint (as of v6) via its .eslintrc doesn't support a way to state that all .ts files needs to be linted (it's supposed to be changed with v7 -> eslint/eslint#10828), and I guess it's why it's forced here via VS Code settings.

Still, I would rather let users configure editors on their own, as the way it's done here may conflict with developer personal preferences (as it's in my case).

@tbarlow12 tbarlow12 closed this Sep 27, 2019
@tbarlow12 tbarlow12 deleted the medikoo/remove-vscode-settings branch March 9, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 issues found on v1.x or feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants