add the ability to define vpcConnector #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why so much pr鈥檚 not merged??? |
|
I would love to see this feature merged? Any issue working through the merge conflict? |
|
Are there any other ways to add a vpcConnector to configuration with serverless? |
|
#191?? VPC isn't available already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR exposes the ability to define vpcConnector for a google cloud function. You can read more documentation about vpcConnectors in the official documentation: https://cloud.google.com/functions/docs/connecting-vpc
Please let me know what needs to be added/changed to get this PR landed 馃憤 I have tested this locally and it works perfectly!