refactor: Make deprecations default mode internally modifyable

serverless · Jul 5, 2021 · 07a69a8 · 07a69a8
1 parent b124152
commit 07a69a8
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/lib/utils/logDeprecation.js b/lib/utils/logDeprecation.js
@@ -28,9 +28,21 @@ const resolveDisabledDeprecationsByService = weakMemoizee((serviceConfig) => {
   return new Set(disabledDeprecations);
 });
 
-const isErrorNotificationMode = (serviceConfig) => {
-  if (notificationModeByEnv) return notificationModeByEnv === 'error';
-  return _.get(serviceConfig, 'deprecationNotificationMode') === 'error';
+const resolveMode = (serviceConfig) => {
+  switch (notificationModeByEnv) {
+    case 'error':
+    case 'warn':
+      return notificationModeByEnv;
+    default:
+  }
+  const modeByConfig = _.get(serviceConfig, 'deprecationNotificationMode');
+  switch (modeByConfig) {
+    case 'error':
+    case 'warn':
+      return modeByConfig;
+    default:
+      return module.exports.defaultMode;
+  }
 };
 
 function writeDeprecation(code, message) {
@@ -70,7 +82,7 @@ module.exports = (code, message, { serviceConfig } = {}) => {
       }
     }
 
-    if (isErrorNotificationMode(serviceConfig)) {
+    if (resolveMode(serviceConfig) === 'error') {
       throw new ServerlessError(
         `${message}\n  More Info: https://www.serverless.com/framework/docs/deprecations/#${code}`,
         `REJECTED_DEPRECATION_${code}`
@@ -84,3 +96,4 @@ module.exports = (code, message, { serviceConfig } = {}) => {
 };
 
 module.exports.triggeredDeprecations = triggeredDeprecations;
+module.exports.defaultMode = 'warn';