Skip to content

Commit

Permalink
refactor(CLI): Modern logs for plugin search command
Browse files Browse the repository at this point in the history
  • Loading branch information
medikoo committed Sep 28, 2021
1 parent 00e016c commit 1463171
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
5 changes: 4 additions & 1 deletion lib/plugins/plugin/search.js
Expand Up @@ -2,6 +2,7 @@

const BbPromise = require('bluebird');
const chalk = require('chalk');
const { legacy, log } = require('@serverless/utils/log');
const cliCommandsSchema = require('../../cli/commands-schema');
const pluginUtils = require('./lib/utils');

Expand Down Expand Up @@ -42,7 +43,9 @@ class PluginSearch {
const pluginCount = filteredPlugins.length;
const query = this.options.query;
const message = `${pluginCount} plugin(s) found for your search query "${query}"\n`;
this.serverless.cli.consoleLog(chalk.yellow(message));
legacy.consoleLog(chalk.yellow(message));
log.notice(`${pluginCount} plugin(s) found matching "${query}":`);
log.notice();

return filteredPlugins;
})
Expand Down
7 changes: 0 additions & 7 deletions test/unit/lib/plugins/plugin/search.test.js
Expand Up @@ -12,7 +12,6 @@ const expect = require('chai').expect;
describe('PluginSearch', () => {
let pluginSearch;
let serverless;
let consoleLogStub;

const plugins = [
{
Expand All @@ -37,11 +36,6 @@ describe('PluginSearch', () => {
serverless.cli = new CLI(serverless);
const options = {};
pluginSearch = new PluginSearch(serverless, options);
consoleLogStub = sinon.stub(serverless.cli, 'consoleLog').returns();
});

afterEach(() => {
serverless.cli.consoleLog.restore();
});

describe('#constructor()', () => {
Expand Down Expand Up @@ -98,7 +92,6 @@ describe('PluginSearch', () => {
pluginSearch.options.query = 'serverless-plugin-1';

return expect(pluginSearch.search()).to.be.fulfilled.then(() => {
expect(consoleLogStub.calledOnce).to.equal(true);
expect(getPluginsStub.calledOnce).to.equal(true);
expect(displayStub.calledOnce).to.equal(true);
});
Expand Down

0 comments on commit 1463171

Please sign in to comment.