Skip to content

Commit

Permalink
refactor: Replace _.flatMap usage (#9948)
Browse files Browse the repository at this point in the history
Co-authored-by: Jonas Matos <js.matos@sidi.org.br>
  • Loading branch information
JonasMatos0 and Jonas Matos committed Sep 15, 2021
1 parent 5c0b270 commit 26b8bd5
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 11 deletions.
19 changes: 13 additions & 6 deletions lib/classes/PluginManager.js
Expand Up @@ -537,19 +537,26 @@ class PluginManager {
}

getEvents(command) {
return _.flatMap(command.lifecycleEvents, (event) => [
`before:${command.key}:${event}`,
`${command.key}:${event}`,
`after:${command.key}:${event}`,
]);
return command.lifecycleEvents
? command.lifecycleEvents.reduce(
(acc, event) =>
acc.concat([
`before:${command.key}:${event}`,
`${command.key}:${event}`,
`after:${command.key}:${event}`,
]),
[]
)
: [];
}

getPlugins() {
return this.plugins;
}

getHooks(events) {
return _.flatMap([].concat(events), (event) => this.hooks[event] || []);
const eventsArray = [].concat(events);
return eventsArray.reduce((acc, event) => acc.concat(this.hooks[event] || []), []);
}

async invoke(commandsArray, allowEntryPoints) {
Expand Down
13 changes: 8 additions & 5 deletions lib/plugins/aws/invokeLocal/index.js
Expand Up @@ -518,7 +518,10 @@ class AwsInvokeLocal {
configuredEnvVars,
envVarsFromOptions
);
const envVarsDockerArgs = _.flatMap(envVars, (value, key) => ['--env', `${key}=${value}`]);
const envVarsDockerArgs = Object.keys(envVars).reduce(
(acc, key) => acc.concat(['--env', `${key}=${envVars[key]}`]),
[]
);

const dockerArgsFromOptions = this.getDockerArgsFromOptions();
const dockerArgs = ['run', '--rm', '-v', `${artifactPath}:/var/task:ro,delegated`].concat(
Expand All @@ -545,11 +548,11 @@ class AwsInvokeLocal {
}

getDockerArgsFromOptions() {
const dockerArgOptions = this.options['docker-arg'];
return _.flatMap([].concat(dockerArgOptions || []), (dockerArgOption) => {
const dockerArgOptions = [].concat(this.options['docker-arg'] || []);
return dockerArgOptions.reduce((acc, dockerArgOption) => {
const splitItems = dockerArgOption.split(' ');
return [splitItems[0], splitItems.slice(1).join(' ')];
});
return acc.concat(splitItems[0], splitItems.slice(1).join(' ') || []);
}, []);
}

async invokeLocalPython(runtime, handlerPath, handlerName, event, context) {
Expand Down

0 comments on commit 26b8bd5

Please sign in to comment.