Skip to content

Commit

Permalink
fix(CLI): Fix handling of provider URL handling
Browse files Browse the repository at this point in the history
  • Loading branch information
medikoo committed Jan 6, 2022
1 parent 80fef65 commit 7ebe133
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion lib/cli/interactive-setup/aws-credentials.js
Expand Up @@ -210,7 +210,7 @@ const steps = {
},
handleProviderCreation: async ({ configuration: { org: orgName }, stepHistory }) => {
const providersUrl = `https://app.serverless.com/${orgName}/settings/providers?source=cli&providerId=new&provider=aws`;
openBrowser(chalk.bold.white(providersUrl));
openBrowser(providersUrl);
legacy.write('To learn more about providers, visit: http://slss.io/add-providers-dashboard\n');
log.notice('To learn more about providers, visit: http://slss.io/add-providers-dashboard');
legacy.write('\nWaiting for creation of AWS Access Role provider...\n');
Expand Down
13 changes: 3 additions & 10 deletions test/unit/lib/cli/interactive-setup/aws-credentials.test.js
Expand Up @@ -6,7 +6,6 @@ const proxyquire = require('proxyquire');
const overrideEnv = require('process-utils/override-env');
const overrideStdoutWrite = require('process-utils/override-stdout-write');
const requireUncached = require('ncjsm/require-uncached');
const chalk = require('chalk');
const { StepHistory } = require('@serverless/utils/telemetry');

const { expect } = chai;
Expand Down Expand Up @@ -485,9 +484,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {

expect(stdoutData).to.include('AWS Access Role provider was successfully created');
expect(mockedOpenBrowser).to.have.been.calledWith(
chalk.bold.white(
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
)
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
);
expect(mockedDisconnect).to.have.been.called;
expect(mockedCreateProviderLink).not.to.have.been.called;
Expand Down Expand Up @@ -562,9 +559,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {

expect(stdoutData).to.include('AWS Access Role provider was successfully created');
expect(mockedOpenBrowser).to.have.been.calledWith(
chalk.bold.white(
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
)
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
);
expect(mockedDisconnect).to.have.been.called;
expect(mockedCreateProviderLink).to.have.been.calledWith(
Expand Down Expand Up @@ -618,9 +613,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {

expect(stdoutData).to.include('Serverless Dashboard is currently unavailable');
expect(mockedOpenBrowser).to.have.been.calledWith(
chalk.bold.white(
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
)
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
);
expect(context.stepHistory.valuesMap()).to.deep.equal(
new Map([['credentialsSetupChoice', '_create_provider_']])
Expand Down

0 comments on commit 7ebe133

Please sign in to comment.