refactor(CLI): Expose function artifact size in deploy summary

serverless · Oct 7, 2021 · 8746100 · 8746100
1 parent c9f2227
commit 8746100
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 29 deletions.
diff --git a/lib/plugins/aws/deploy/lib/uploadArtifacts.js b/lib/plugins/aws/deploy/lib/uploadArtifacts.js
@@ -29,7 +29,7 @@ module.exports = {
 
   async uploadArtifacts() {
     const artifactFilePaths = [
-      ...this.getFunctionArtifactFilePaths(),
+      ...(await this.getFunctionArtifactFilePaths()),
       ...this.getLayerArtifactFilePaths(),
     ];
     if (artifactFilePaths.length === 1) {
@@ -112,35 +112,41 @@ module.exports = {
     return response;
   },
 
-  getFunctionArtifactFilePaths() {
+  async getFunctionArtifactFilePaths() {
     const functionNames = this.serverless.service.getAllFunctions();
     return _.uniq(
-      functionNames
-        .map((name) => {
-          const functionObject = this.serverless.service.getFunction(name);
-          if (functionObject.image) return null;
-          const functionArtifactFileName = this.provider.naming.getFunctionArtifactName(name);
-          functionObject.package = functionObject.package || {};
-          const artifactFilePath =
-            functionObject.package.artifact || this.serverless.service.package.artifact;
-
-          if (
-            !artifactFilePath ||
-            (this.serverless.service.artifact && !functionObject.package.artifact)
-          ) {
+      (
+        await Promise.all(
+          functionNames.map(async (name) => {
+            const functionObject = this.serverless.service.getFunction(name);
+            if (functionObject.image) return null;
+            const functionArtifactFileName = this.provider.naming.getFunctionArtifactName(name);
+            functionObject.package = functionObject.package || {};
+            let artifactFilePath =
+              functionObject.package.artifact || this.serverless.service.package.artifact;
+
             if (
-              this.serverless.service.package.individually ||
-              functionObject.package.individually
+              !artifactFilePath ||
+              (this.serverless.service.artifact && !functionObject.package.artifact)
             ) {
-              const artifactFileName = functionArtifactFileName;
-              return path.join(this.packagePath, artifactFileName);
+              if (
+                this.serverless.service.package.individually ||
+                functionObject.package.individually
+              ) {
+                const artifactFileName = functionArtifactFileName;
+                artifactFilePath = path.join(this.packagePath, artifactFileName);
+              } else {
+                artifactFilePath = path.join(
+                  this.packagePath,
+                  this.provider.naming.getServiceArtifactName()
+                );
+              }
             }
-            return path.join(this.packagePath, this.provider.naming.getServiceArtifactName());
-          }
-
-          return artifactFilePath;
-        })
-        .filter(Boolean)
+            functionObject.artifactSize = (await this.getFileStats(artifactFilePath)).size;
+            return artifactFilePath;
+          })
+        )
+      ).filter(Boolean)
     );
   },
 
@@ -168,7 +174,7 @@ module.exports = {
     legacy.log('Uploading artifacts...');
 
     const artifactFilePaths = [
-      ...this.getFunctionArtifactFilePaths(),
+      ...(await this.getFunctionArtifactFilePaths()),
       ...this.getLayerArtifactFilePaths(),
     ];
 

diff --git a/lib/plugins/aws/info/display.js b/lib/plugins/aws/info/display.js
@@ -1,7 +1,8 @@
 'use strict';
 
 const chalk = require('chalk');
-const { legacy, isVerboseMode } = require('@serverless/utils/log');
+const filesize = require('filesize');
+const { legacy, isVerboseMode, style } = require('@serverless/utils/log');
 
 module.exports = {
   displayServiceInfo() {
@@ -131,7 +132,11 @@ module.exports = {
       const outputSectionItems = [];
       info.functions.forEach((f) => {
         functionsMessage += `\n  ${f.name}: ${f.deployedName}`;
-        outputSectionItems.push(`${f.name}: ${f.deployedName}`);
+        outputSectionItems.push(
+          `${f.name}: ${f.deployedName}${
+            f.artifactSize ? style.aside(` (${filesize(f.artifactSize)})`) : ''
+          }`
+        );
       });
       this.serverless.addServiceOutputSection('functions', outputSectionItems);
     } else {

diff --git a/lib/plugins/aws/info/getStackInfo.js b/lib/plugins/aws/info/getStackInfo.js
@@ -69,9 +69,11 @@ module.exports = {
 
         // Functions
         this.serverless.service.getAllFunctions().forEach((func) => {
+          const functionObj = this.serverless.service.getFunction(func);
           const functionInfo = {};
           functionInfo.name = func;
-          functionInfo.deployedName = this.serverless.service.getFunction(func).name;
+          functionInfo.deployedName = functionObj.name;
+          functionInfo.artifactSize = functionObj.artifactSize;
           this.gatheredData.info.functions.push(functionInfo);
         });
 

diff --git a/test/unit/lib/plugins/aws/info/getStackInfo.test.js b/test/unit/lib/plugins/aws/info/getStackInfo.test.js
@@ -94,10 +94,12 @@ describe('#getStackInfo()', () => {
           {
             name: 'hello',
             deployedName: 'my-service-dev-hello',
+            artifactSize: undefined,
           },
           {
             name: 'world',
             deployedName: 'customized',
+            artifactSize: undefined,
           },
         ],
         layers: [