Refactor AWS SDK usage and update Lambda permissions

serverless · Apr 17, 2024 · c8974c1 · c8974c1
1 parent 03854a6
commit c8974c1
Showing 1 changed file with 3 additions and 16 deletions.
diff --git a/lib/plugins/aws/customResources/resources/utils.js b/lib/plugins/aws/customResources/resources/utils.js
@@ -1,6 +1,5 @@
 'use strict';
 
-const AWS = require('aws-sdk');
 const https = require('https');
 const url = require('url');
 
@@ -97,23 +96,11 @@ const MAX_AWS_REQUEST_TRY = (() => {
   return userValue >= 0 ? userValue : DEFAULT_MAX_AWS_REQUEST_TRY;
 })();
 
-const getServiceInstance = (nameInput) => {
-  let name;
-  let params = {};
-  if (typeof nameInput === 'string') {
-    name = nameInput;
-  } else {
-    name = nameInput.name;
-    params = nameInput.params;
-  }
-  return new AWS[name](params);
-};
+async function retryableAwsCall(awsApiFunc) {
 
-async function awsRequest(service, method, ...args) {
-  const serviceInstance = getServiceInstance(service);
   const callAws = async (requestTry) => {
     try {
-      return await serviceInstance[method](...args).promise();
+      return await awsApiFunc();
     } catch (error) {
       if (
         requestTry < MAX_AWS_REQUEST_TRY &&
@@ -136,5 +123,5 @@ module.exports = {
   getLambdaArn,
   handlerWrapper,
   wait,
-  awsRequest,
+  awsRequest: retryableAwsCall,
 };