feat(AWS Deploy): Support disableRollback parameter (#10236)

serverless · Nov 25, 2021 · c9fefce · c9fefce
1 parent a4fa498
commit c9fefce
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/docs/providers/aws/guide/serverless.yml.md b/docs/providers/aws/guide/serverless.yml.md
@@ -261,6 +261,7 @@ provider:
   stackParameters:
     - ParameterKey: 'Keyname'
       ParameterValue: 'Value'
+  disableRollback: true # To be used for non-production environment
   rollbackConfiguration:
     MonitoringTimeInMinutes: 20
     RollbackTriggers:

diff --git a/lib/plugins/aws/deploy/lib/createStack.js b/lib/plugins/aws/deploy/lib/createStack.js
@@ -53,6 +53,11 @@ module.exports = {
       params.NotificationARNs = this.serverless.service.provider.notificationArns;
     }
 
+    if (this.serverless.service.provider.disableRollback) {
+      delete params.OnFailure;
+      params.DisableRollback = this.serverless.service.provider.disableRollback;
+    }
+
     return this.provider
       .request('CloudFormation', 'createStack', params)
       .then((cfData) => this.monitorStack('create', cfData));

diff --git a/lib/plugins/aws/lib/updateStack.js b/lib/plugins/aws/lib/updateStack.js
@@ -62,6 +62,11 @@ module.exports = {
       params.Parameters = this.serverless.service.provider.stackParameters;
     }
 
+    if (this.serverless.service.provider.disableRollback) {
+      delete params.OnFailure;
+      params.DisableRollback = this.serverless.service.provider.disableRollback;
+    }
+
     return this.provider
       .request('CloudFormation', 'createStack', params)
       .then((cfData) => this.monitorStack('create', cfData));
@@ -133,6 +138,10 @@ module.exports = {
       params.RollbackConfiguration = this.serverless.service.provider.rollbackConfiguration;
     }
 
+    if (this.serverless.service.provider.disableRollback) {
+      params.DisableRollback = this.serverless.service.provider.disableRollback;
+    }
+
     let cfData;
     try {
       cfData = await this.provider.request('CloudFormation', 'updateStack', params);

diff --git a/lib/plugins/aws/provider.js b/lib/plugins/aws/provider.js
@@ -844,6 +844,7 @@ class AwsProvider {
             },
             deploymentPrefix: { type: 'string' },
             disableDefaultOutputExportNames: { const: true },
+            disableRollback: { const: true },
             endpointType: {
               anyOf: ['REGIONAL', 'EDGE', 'PRIVATE'].map(caseInsensitive),
             },