refactor(AWS Deploy): Improve error message

serverless · Oct 7, 2021 · d071c5f · d071c5f
1 parent 02be86c
commit d071c5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/plugins/aws/package/lib/mergeCustomProviderResources.js b/lib/plugins/aws/package/lib/mergeCustomProviderResources.js
@@ -72,7 +72,8 @@ module.exports = {
             // default includes any future attributes we don't know about yet.
             default:
               throw new ServerlessError(
-                `${resourceName}: Sorry, extending the ${extensionAttributeName} resource ` +
+                `Cannot extend "${resourceName}" resource, as extending ` +
+                  `the "${extensionAttributeName}" ` +
                   'attribute at this point is not supported. Feel free to propose support ' +
                   'for it in the Framework issue tracker: ' +
                   'https://github.com/serverless/serverless/issues',

diff --git a/test/unit/lib/plugins/aws/package/lib/mergeCustomProviderResources.test.js b/test/unit/lib/plugins/aws/package/lib/mergeCustomProviderResources.test.js
@@ -4,6 +4,7 @@ const path = require('path');
 const expect = require('chai').expect;
 const AwsPackage = require('../../../../../../../lib/plugins/aws/package/index');
 const Serverless = require('../../../../../../../lib/Serverless');
+const ServerlessError = require('../../../../../../../lib/serverless-error');
 
 describe('mergeCustomProviderResources', () => {
   let serverless;
@@ -299,9 +300,9 @@ describe('mergeCustomProviderResources', () => {
         },
       };
 
-      expect(() => awsPackage.mergeCustomProviderResources()).to.throw(
-        /SampleResource: Sorry, extending the unsupported resource attribute at this point is not supported/
-      );
+      expect(() => awsPackage.mergeCustomProviderResources())
+        .to.throw(ServerlessError)
+        .with.property('code', 'RESOURCE_EXTENSION_UNSUPPORTED_ATTRIBUTE');
     });
   });
 });