refactor: Ensure constient returns

serverless · Sep 15, 2020 · d5833f8 · d5833f8
1 parent 370c097
commit d5833f8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/lib/classes/Utils.js b/lib/classes/Utils.js
@@ -45,11 +45,11 @@ class Utils {
   }
 
   writeFileDir(filePath) {
-    return fse.mkdirsSync(path.dirname(filePath));
+    fse.mkdirsSync(path.dirname(filePath));
   }
 
   writeFileSync(filePath, contents, cycles) {
-    return writeFileSync(filePath, contents, cycles);
+    writeFileSync(filePath, contents, cycles);
   }
 
   writeFile(filePath, contents, cycles) {

diff --git a/lib/classes/Utils.test.js b/lib/classes/Utils.test.js
@@ -62,15 +62,11 @@ describe('Utils', () => {
   describe('#writeFileDir()', () => {
     it('should create a directory for the path of the given file', () => {
       const tmpDirPath = getTmpDirPath();
-      const rootDir = serverless.utils.writeFileDir(
-        path.join(tmpDirPath, 'foo', 'bar', 'somefile.js')
-      );
-
-      expect(serverless.utils.dirExistsSync(path.join(rootDir, 'foo', 'bar'))).to.equal(true);
+      const fileDir = path.join(tmpDirPath, 'foo', 'bar');
+      serverless.utils.writeFileDir(path.join(fileDir, 'somefile.js'));
+      expect(serverless.utils.dirExistsSync(fileDir)).to.equal(true);
       // it should only create the directories and not the file
-      expect(
-        serverless.utils.fileExistsSync(path.join(rootDir, 'foo', 'bar', 'somefile.js'))
-      ).to.equal(false);
+      expect(serverless.utils.fileExistsSync(path.join(fileDir, 'somefile.js'))).to.equal(false);
     });
   });