Skip to content

Commit

Permalink
Replace _.flatMap with native property assignment
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonas Matos committed Sep 13, 2021
1 parent 6087fa3 commit d5a85cb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
5 changes: 3 additions & 2 deletions lib/classes/PluginManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ class PluginManager {
}

getEvents(command) {
return _.flatMap(command.lifecycleEvents, (event) => [
return command.lifecycleEvents.flatMap((event) => [
`before:${command.key}:${event}`,
`${command.key}:${event}`,
`after:${command.key}:${event}`,
Expand All @@ -549,7 +549,8 @@ class PluginManager {
}

getHooks(events) {
return _.flatMap([].concat(events), (event) => this.hooks[event] || []);
const eventsArray = [].concat(events);
return eventsArray.flatMap((event) => this.hooks[event] || []);
}

async invoke(commandsArray, allowEntryPoints) {
Expand Down
10 changes: 7 additions & 3 deletions lib/plugins/aws/invokeLocal/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,10 @@ class AwsInvokeLocal {
configuredEnvVars,
envVarsFromOptions
);
const envVarsDockerArgs = _.flatMap(envVars, (value, key) => ['--env', `${key}=${value}`]);
const envVarsDockerArgs = Object.keys(envVars).reduce(
(acc, key) => acc.concat(['--env', `${key}=${envVars[key]}`]),
[]
);

const dockerArgsFromOptions = this.getDockerArgsFromOptions();
const dockerArgs = ['run', '--rm', '-v', `${artifactPath}:/var/task:ro,delegated`].concat(
Expand All @@ -545,8 +548,9 @@ class AwsInvokeLocal {
}

getDockerArgsFromOptions() {
const dockerArgOptions = this.options['docker-arg'];
return _.flatMap([].concat(dockerArgOptions || []), (dockerArgOption) => {
const dockerArgOptions = [].concat(this.options['docker-arg'] || []);

return dockerArgOptions.flatMap((dockerArgOption) => {
const splitItems = dockerArgOption.split(' ');
return [splitItems[0], splitItems.slice(1).join(' ')];
});
Expand Down

0 comments on commit d5a85cb

Please sign in to comment.