fix(AWS Cognito): Correct logicalIds based on triggers (#9592)

* fix: strips nonalphanumerical characters * fix: strips nonalphanumerical characters * test: strips nonalphanumerical characters * test: strips nonalphanumerical characters * fix: prettier check
serverless · Jun 14, 2021 · f4c9b58 · f4c9b58
1 parent 4a732e2
commit f4c9b58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/plugins/aws/lib/naming.js b/lib/plugins/aws/lib/naming.js
@@ -519,7 +519,7 @@ module.exports = {
       functionName
     )}LambdaPermissionCognitoUserPool${this.normalizeNameToAlphaNumericOnly(
       poolId
-    )}TriggerSource${triggerSource}`;
+    )}TriggerSource${this.normalizeNameToAlphaNumericOnly(triggerSource)}`;
   },
   getLambdaAlbPermissionLogicalId(functionName) {
     return `${this.getNormalizedFunctionName(functionName)}LambdaPermissionAlb`;

diff --git a/test/unit/lib/plugins/aws/lib/naming.test.js b/test/unit/lib/plugins/aws/lib/naming.test.js
@@ -705,9 +705,11 @@ describe('#naming()', () => {
         sdk.naming.getLambdaCognitoUserPoolPermissionLogicalId(
           'functionName',
           'Pool1',
-          'CustomMessage'
+          'PreSignUp_ExternalProvider'
         )
-      ).to.equal('FunctionNameLambdaPermissionCognitoUserPoolPool1TriggerSourceCustomMessage');
+      ).to.equal(
+        'FunctionNameLambdaPermissionCognitoUserPoolPool1TriggerSourcePreSignUpExternalProvider'
+      );
     });
 
     describe('#getLambdaAlbPermissionLogicalId()', () => {