Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Modern logs for plugin ... commands #10016

Merged
merged 8 commits into from Sep 28, 2021
Merged

CLI: Modern logs for plugin ... commands #10016

merged 8 commits into from Sep 28, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 28, 2021

Addresses #9860

Additionally fixed handling of corner-case where local installation of serverless is removed during a command run

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #10016 (50e9e1e) into master (6f88c11) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10016      +/-   ##
==========================================
- Coverage   86.03%   86.01%   -0.02%     
==========================================
  Files         332      332              
  Lines       13248    13276      +28     
==========================================
+ Hits        11398    11420      +22     
- Misses       1850     1856       +6     
Impacted Files Coverage Δ
lib/cli/handle-error.js 86.00% <35.71%> (-2.66%) ⬇️
commands/plugin-install.js 63.51% <66.66%> (+0.27%) ⬆️
lib/utils/telemetry/generatePayload.js 90.47% <66.66%> (-0.59%) ⬇️
lib/Serverless.js 68.88% <100.00%> (ø)
lib/plugins/plugin/install.js 94.62% <100.00%> (+0.30%) ⬆️
lib/plugins/plugin/lib/utils.js 90.69% <100.00%> (+0.95%) ⬆️
lib/plugins/plugin/search.js 100.00% <100.00%> (ø)
lib/plugins/plugin/uninstall.js 94.59% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f88c11...50e9e1e. Read the comment docs.

@medikoo medikoo merged commit 1463171 into master Sep 28, 2021
@medikoo medikoo deleted the 0927-modern-logs branch September 28, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant