Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in the newest Serverless version - 1.61.2 #7225

Closed
turakvlad opened this issue Jan 16, 2020 · 6 comments
Closed

A bug in the newest Serverless version - 1.61.2 #7225

turakvlad opened this issue Jan 16, 2020 · 6 comments
Assignees
Labels

Comments

@turakvlad
Copy link

Bug Report

Description

  1. What did you do?

I update the Serverless framework from 1.61.1 to 1.61.2.

  1. What happened?

My Serverless config stopped working.

My simplified config:

service:
  name: sa-weekly-report

provider:
  name: aws
  runtime: nodejs10.x
  stage: ${env:NODE_ENV, 'dev'}
  region: ${opt:region, 'eu-central-1'}

custom:
  customDomain:
    domainName: sa-weekly-report.startdeliver.io
    certificateName: '*.startdeliver.io'
    endpointType: 'regional'

functions:
  # Some functions go here...  

plugins:
  - serverless-domain-manager

I invoke the domain's creation with sls create_domain.

  1. What should've happened?

It should work as it worked in 1.61.1. But instead I am getting this:

  Error --------------------------------------------------
 
  Error: Error: '*******************************' was not created in API Gateway.
  ConfigError: Missing region in config
      at createDomainName.catch (/root/app/node_modules/serverless-domain-manager/index.js:108:15)
      at process._tickCallback (internal/process/next_tick.js:68:7)
 
     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.
 
  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com
 
  Your Environment Information ---------------------------
     Operating System:          linux
     Node Version:              10.18.1
     Framework Version:         1.61.2
     Plugin Version:            3.2.7
     SDK Version:               2.2.1
     Components Core Version:   1.1.2
     Components CLI Version:    1.4.0
 

Exited with code exit status 1

Similar or dependent issues:

@medikoo
Copy link
Contributor

medikoo commented Jan 16, 2020

@turakvlad with v1.61.2 we've fixed one internal issue, and it appears that domain manager relied on that specific quirk of a framework (which technically was buggy design).

Issue ideally should be fixed in domain manager plugin

@eljulians
Copy link

Had the same problem also with 1.61.2, had to downgrade it.

@medikoo Does that mean that we shouldn't update until serverless-domain-manager fixes it? Thanks!

@medikoo
Copy link
Contributor

medikoo commented Jan 16, 2020

@medikoo Does that mean that we shouldn't update until serverless-domain-manager fixes it? Thanks!

Yes, if you need to rely on this plugin, then best if you hold with upgrade, until PR on plugin side gets merged and published

@eljulians
Copy link

Great, thanks!

@jonoirwinrsa
Copy link

Not sure if I am experiencing the same issue but 1.61.2 doesn't build for me. Downgrading to 1.60 fixed the issue.

Builds break after packing external modules and before Packaging service

Serverless: Packing external modules: date-fns@^2.4.1
<-- just exits here on 1.61.2
Serverless: Packaging service...

@medikoo
Copy link
Contributor

medikoo commented Jan 17, 2020

@jonoirwinrsa if you feel it's an issue in a framework (no plugins are involved) please open a dedicated issue, otherwise you need to report at given plugin repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants