Fix schema for resource tags. #8314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8314 +/- ##
==========================================
- Coverage 88.08% 88.01% -0.07%
==========================================
Files 250 249 -1
Lines 9368 9307 -61
==========================================
- Hits 8252 8192 -60
+ Misses 1116 1115 -1
Continue to review full report at Codecov.
|
medikoo
suggested changes
Oct 1, 2020
| @@ -356,9 +356,8 @@ class AwsProvider { | |||
| awsResourceTags: { | |||
| type: 'object', | |||
| patternProperties: { | |||
| '^(?!aws:)[\\w./=+-]{1,128}$': { | |||
| '^(?!aws:)[\\w./=+-:]{1,128}$': { | |||
There was a problem hiding this comment.
I think we need to move - so it's listed last, otherwise +-: implies a range
There was a problem hiding this comment.
Thanks @medikoo. I've updated it.
medikoo
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS allows for resource tags to have colons in them. In fact, they use it themselves for their reserved tags and they recommend their use in their best practices. Serverless config schema validation should also allow for it.
The schema validation is based on the documentation in this page: https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_Tag.html.
This PR closes #8304.