Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS tag value pattern #8391

Closed
wants to merge 1 commit into from

Conversation

mvanzoest-rcd
Copy link

Closes: #8390

Inspired by this PR, which also does not include test modifications, but I would be happy to write a couple tests if given guidance on the best place for those tests.

@medikoo
Copy link
Contributor

medikoo commented Oct 13, 2020

Thanks for opening but issue in question was already fixed with #8314.

And it's in since v2.5.0 (ensure to use latest version!)

@mvanzoest-rcd
Copy link
Author

Thanks for opening but issue in question was already fixed with #8314.

And it's in since v2.5.0 (ensure to use latest version!)

What are you talking about? I added an underscore and an at-sign...

@medikoo
Copy link
Contributor

medikoo commented Oct 13, 2020

What are you talking about? I added an underscore and an at-sign...

Have you checked whether you observe same issue with latest version of a Framework?

Note that what you've updated is pattern for tag name (which is correct) and not tag value

@mvanzoest-rcd
Copy link
Author

Have you checked whether you observe same issue with latest version of a Framework?

Note that what you've updated is pattern for tag name (which is correct) and not tag value

Ahh gotcha. Yes, you are right, 2.5.0+ does not give the warnings. Thanks for the clarifications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag value pattern does not respect @
2 participants