Replace fs-ext with equivalent native fs when possible

[juanjoDiaz]

These are the functions that I've found in the codebase which are in fs and can be used from fsPromise or using util.promisify directly

• exists (Replace fse.exists with fs.promises.access #8788)
• realpath (refactor: Replace fse.promises.realpath with fs.promises.realpath #8853)
• writeFile (refactor: Replace fse.writeFile with fs.promises.writeFile #9870)
• rename (refactor: Replace fse.rename with fs.promises.rename #9605)
• chmod (refactor: Replace fse.chmod with fs.promises.chmod #9647)
• createWriteStream (refactor: Replace fse.createWriteStream with fs.createWriteStream #9687)
• unlink (refactor: Replace fse.unlink with fs.promises.unlink #9754)
• readdir (refactor: Replace fse.readdir with fs.promises.readdir #9780)
• stat (refactor: Replace fse.stat with fs.promises.stat #9845)
• access (refactor: Replace fse.access with fs.promises.access #9915)
• readFile (refactor: Replace fse.readFile with fs.promises.readFile #9935)

[medikoo]

@juanjoDiaz Thanks for opening that. Yes, we definitely can rely on fs in that case.

Fact that in those places fs-extra is used, I believe is purely for convenience of using one fs collection in module. Note that fs-extra aliases all fs functions. It's like fs with extras, such usage is actually advertised in fs-extra documentation.

Anyway I'm totally after relying on fs.promises directly instead (with exclusion of sync variants and createWriteStream, as those are not promise returning functions)

PR is welcome!

[sdas13]

Hello,
Can I work on some of the areas?

[medikoo]

@sdas13 definitely! PR's welcome

[pgrzesik]

Hello @sdas13 👋 Looks like all refactors from the list has been covered thanks to your contributions 🙇 Do you see any other potential refactorings from fse that could be replaced by native utilities?

[sdas13]

Hey @pgrzesik 😃
Couple of async fse functions that can be refactored are access and readFile. There are few fse functions like ensureFile, ensureDir, readJson, remove, mkdirs which are not fs native. Although remove and mkdirs can be replaced by rm and mkdir respectively. Also all the sync counterparts can be refactored.

[medikoo]

Also all the sync counterparts can be refactored.

That is in scope of #8604

[pgrzesik]

@sdas13 I think that the functions that don't have a direct native replacement are okay to stay, what do you think? cc @medikoo

[medikoo]

@sdas13 I think that the functions that don't have a direct native replacement are okay to stay, what do you think? cc @medikoo

yes definitely I wouldn't touch them (there's no goal to get rid of fs-extra completely)

Therefore it appears that fse.access and fse.readFile are still missing refactor (I've added them to top list)

[sdas13]

yes definitely I wouldn't touch them (there's no goal to get rid of fs-extra completely)

Agreed !

[pgrzesik]

PR #9935 marks the last piece of the refactoring as a part of this task, I think we're fine to close it, what do you think @sdas13 @medikoo ?

[medikoo]

@pgrzesik definitely! Great thanks @sdas13 for making that happen!