Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace fse.createWriteStream with fs.createWriteStream #9687

Merged
merged 1 commit into from Jul 5, 2021

Conversation

sdas13
Copy link
Contributor

@sdas13 sdas13 commented Jul 2, 2021

Addresses: #8605

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #9687 (12e2e94) into master (01f1586) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9687   +/-   ##
=======================================
  Coverage   86.13%   86.14%           
=======================================
  Files         327      327           
  Lines       12504    12511    +7     
=======================================
+ Hits        10770    10777    +7     
  Misses       1734     1734           
Impacted Files Coverage Δ
lib/utils/eventuallyUpdate.js 28.03% <50.00%> (+0.67%) ⬆️
lib/plugins/package/package.js 96.15% <0.00%> (ø)
lib/plugins/aws/package/compile/events/kafka.js 98.33% <0.00%> (+0.08%) ⬆️
lib/cli/interactive-setup/aws-credentials.js 89.06% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f1586...12e2e94. Read the comment docs.

@sdas13 sdas13 marked this pull request as ready for review July 2, 2021 18:18
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sdas13 🙇

@pgrzesik pgrzesik changed the title refactor: Replace fse.createWriteStream with fs.createWriteStream refactor: Replace fse.createWriteStream with fs.createWriteStream Jul 5, 2021
@pgrzesik pgrzesik merged commit 3500f64 into serverless:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants