Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type definition for provider.logRetentionInDays #8843

Closed
frozenbonito opened this issue Jan 28, 2021 · 0 comments · Fixed by #8844
Closed

Missing type definition for provider.logRetentionInDays #8843

frozenbonito opened this issue Jan 28, 2021 · 0 comments · Fixed by #8844

Comments

@frozenbonito
Copy link
Contributor

provider.logRetentionInDays property requires number, but there is no type definition for it in config schema.
This issue breaks type coercion (#8319) and prevents making it configurable by option or environment variable.

serverless.yml
service: myservice

provider:
  name: aws
  region: us-east-1
  runtime: nodejs12.x
  logRetentionInDays: ${opt:log-retention}
  lambdaHashingVersion: 20201221

functions:
  lambdaAtEdge:
    handler: index.handler
sls package --log-retention 7 output
$ sls package --log-retention 7
Serverless: Configuration warning at 'provider.logRetentionInDays': should be equal to one of the allowed values
Serverless:  
Serverless: Learn more about configuration validation here: http://slss.io/configuration-validation
Serverless:  
Serverless: Packaging service...
Serverless: Excluding development dependencies...

Installed version

Framework Core: 2.21.1 (local)
Plugin: 4.4.2
SDK: 2.3.2
Components: 3.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants