Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Config Schema): Add type to logRetentionInDays #8844

Merged

Conversation

frozenbonito
Copy link
Contributor

Closes: #8843

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #8844 (b7cefc6) into master (7ccb176) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8844   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         265      265           
  Lines        9910     9910           
=======================================
  Hits         8697     8697           
  Misses       1213     1213           
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccb176...b7cefc6. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @frozenbonito, great catch 🙇

@pgrzesik pgrzesik changed the title fix(AWS Lambda): Add type to logRetentionInDays fix(Config Schema): Add type to logRetentionInDays Jan 28, 2021
@pgrzesik pgrzesik merged commit ec12a2b into serverless:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type definition for provider.logRetentionInDays
2 participants