Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting SASL/SCRAM auth with MSK events #9224

Closed
pedrocava opened this issue Apr 1, 2021 · 4 comments · Fixed by #11060
Closed

Supporting SASL/SCRAM auth with MSK events #9224

pedrocava opened this issue Apr 1, 2021 · 4 comments · Fixed by #11060

Comments

@pedrocava
Copy link

pedrocava commented Apr 1, 2021

Use case description

There's an MSK cluster running with SASL auth. There's a backend producing events and a Serverless application listening to certain topics, using messages to trigger parametrized reactions, such as calling other lambda functions or uploading data to a DB.

Proposed solution

AWS has recently started supporting SASL auth for MSK events. Unfortunately, this feature's documentation in CloudFormation is rather scarce.

Extending the convention @pgrzesik provided here, we should have something like:

functions:
  compute:
    handler: handler.compute
    events:
      - msk:
          arn: arn:aws:kafka:region:XXXXXX:Cluster/xxx
          topic: kafka-topic
          startingPosition: LATEST
          batchSize: 1000
          saslScram512: arn:aws:secrets_manager:xxxxxxxxx

The ARN provided to saslScram512 should be associated with the secret created during the SASL setup, described in more detail here. Much like the accessConfigurations field in kafka events works.

@medikoo
Copy link
Contributor

medikoo commented Apr 2, 2021

@pedrocava great thanks for that request. Proposal looks good enough, and I think we can jump to PR directly (which is welcome!).

@pgrzesik
Copy link
Contributor

pgrzesik commented Apr 6, 2021

Thanks @pedrocava - it looks great 👍 It will be a bit different than for kafka, where these configurations are nested under accessConfigurations, however, I see that in case of msk the saslScram512 is the only possible configuration which suggests that in this case, nesting under accessConfigurations doesn't make much sense. 👍

@renetta96
Copy link

hello, is this supported yet?

@pgrzesik
Copy link
Contributor

Hello @renetta96 👋 At the moment it's not supported, but we'd be more than happy to accept a community contribution for it 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants