-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AWS MSK): Add support for SASL/SCRAM authentication #11060
Conversation
Hello @Arielgordon123 - thanks a lot for the proposed change. Is there a reason why you changed the proposed configuration scheme in comparison to what was agreed upon in the related issue? |
Hi @pgrzesik I've fixed that, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, I have a few minor suggestions and we should be good to go
Codecov Report
@@ Coverage Diff @@
## main #11060 +/- ##
=======================================
Coverage 85.91% 85.92%
=======================================
Files 311 311
Lines 13152 13156 +4
=======================================
+ Hits 11300 11304 +4
Misses 1852 1852
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Arielgordon123, it looks great 👍
Any predictions for the release of this version? |
Hey @valdirluiz - no specific date yet, but probably later this week or early next week. |
Add missing SourceAccessConfiguration in the event source mapping config
Closes: #9224