Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AWS MSK): Add support for SASL/SCRAM authentication #11060

Merged
merged 6 commits into from
May 15, 2022

Conversation

Arielgordon123
Copy link
Contributor

Add missing SourceAccessConfiguration in the event source mapping config

Closes: #9224

@pgrzesik
Copy link
Contributor

Hello @Arielgordon123 - thanks a lot for the proposed change. Is there a reason why you changed the proposed configuration scheme in comparison to what was agreed upon in the related issue?

@Arielgordon123
Copy link
Contributor Author

Hi @pgrzesik I've fixed that,
now it would work like the proposal in the related issue

@Arielgordon123 Arielgordon123 changed the title feat(AWS MSK): Support SourceAccessConfigurations feat(AWS MSK): Add support for SASL/SCRAM authentication May 11, 2022
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I have a few minor suggestions and we should be good to go

docs/providers/aws/events/msk.md Outdated Show resolved Hide resolved
scripts/test/integration-setup/cloudformation.yml Outdated Show resolved Hide resolved
test/integration/aws/infra-dependent/msk.test.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #11060 (8727415) into main (3b50294) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8727415 differs from pull request most recent head 203245c. Consider uploading reports for the commit 203245c to get more accurate results

@@           Coverage Diff           @@
##             main   #11060   +/-   ##
=======================================
  Coverage   85.91%   85.92%           
=======================================
  Files         311      311           
  Lines       13152    13156    +4     
=======================================
+ Hits        11300    11304    +4     
  Misses       1852     1852           
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/msk/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b50294...203245c. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Arielgordon123, it looks great 👍

@pgrzesik pgrzesik merged commit 184cb03 into serverless:main May 15, 2022
@valdirluiz
Copy link

Any predictions for the release of this version?

@pgrzesik
Copy link
Contributor

Hey @valdirluiz - no specific date yet, but probably later this week or early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting SASL/SCRAM auth with MSK events
3 participants