Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use async in lib/plugins/package #9644

Merged
merged 3 commits into from Jul 2, 2021

Conversation

nyamba
Copy link
Contributor

@nyamba nyamba commented Jun 26, 2021

refactoring promise returning functions to async in folder lib/plugins/package

issue: #8368

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #9644 (81231be) into master (3e14f06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 81231be differs from pull request most recent head 23f2827. Consider uploading reports for the commit 23f2827 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9644   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files         327      327           
  Lines       12507    12510    +3     
=======================================
+ Hits        10773    10776    +3     
  Misses       1734     1734           
Impacted Files Coverage Δ
lib/plugins/package/lib/packageService.js 93.33% <ø> (ø)
lib/plugins/package/lib/zipService.js 96.33% <ø> (ø)
lib/cli/interactive-setup/aws-credentials.js 89.06% <100.00%> (+0.17%) ⬆️
lib/plugins/package/package.js 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e14f06...23f2827. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nyamba - it looks great. Before merging, could you rebase on top of current master branch and push again? We've changed the CI test suite a bit to include Node 16 and I'd like to verify it runs all updated CI jobs correctly. Thanks in advance 🙇

@nyamba
Copy link
Contributor Author

nyamba commented Jul 2, 2021

Hello @pgrzesik, pushed it.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nyamba - it looks great 👏

@pgrzesik pgrzesik changed the title Async lib/plugins/package refactor: Use async in lib/plugins/package Jul 2, 2021
@pgrzesik pgrzesik merged commit db67b35 into serverless:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants