-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use async
in lib/plugins/package
#9644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9644 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 327 327
Lines 12507 12510 +3
=======================================
+ Hits 10773 10776 +3
Misses 1734 1734
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nyamba - it looks great. Before merging, could you rebase on top of current master
branch and push again? We've changed the CI test suite a bit to include Node 16 and I'd like to verify it runs all updated CI jobs correctly. Thanks in advance 🙇
Hello @pgrzesik, pushed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nyamba - it looks great 👏
async
in lib/plugins/package
refactoring promise returning functions to async in folder
lib/plugins/package
issue: #8368