New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Templates): Switch from serverless-webpack to serverless-esbuild in aws-nodejs-typescript
#9962
feat(Templates): Switch from serverless-webpack to serverless-esbuild in aws-nodejs-typescript
#9962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simpler as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriencaccia Great thanks for this improvement!
We'll be happy to take it, still, it seems to require an update in tests (I believe it's due to changes to generated result) - see CI fail
f44c654
to
4b0ead2
Compare
Codecov Report
@@ Coverage Diff @@
## master #9962 +/- ##
==========================================
+ Coverage 86.17% 86.20% +0.03%
==========================================
Files 330 329 -1
Lines 13037 13032 -5
==========================================
Hits 11234 11234
+ Misses 1803 1798 -5 Continue to review full report at Codecov.
|
I fixed the failing test 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adriencaccia !
Thanks @adriencaccia |
This PR switched from
serverless-webpack
toserverless-esbuild
to handle lambdas packaging.The gains are: