Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Templates): Switch from serverless-webpack to serverless-esbuild in aws-nodejs-typescript #9962

Conversation

adriencaccia
Copy link
Contributor

This PR switched from serverless-webpack to serverless-esbuild to handle lambdas packaging.

The gains are:

  • blazing fast packaging time
  • much less configuration

mnapoli
mnapoli previously approved these changes Sep 15, 2021
Copy link
Contributor

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simpler as well!

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriencaccia Great thanks for this improvement!

We'll be happy to take it, still, it seems to require an update in tests (I believe it's due to changes to generated result) - see CI fail

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #9962 (4b0ead2) into master (28d230f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9962      +/-   ##
==========================================
+ Coverage   86.17%   86.20%   +0.03%     
==========================================
  Files         330      329       -1     
  Lines       13037    13032       -5     
==========================================
  Hits        11234    11234              
+ Misses       1803     1798       -5     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d230f...4b0ead2. Read the comment docs.

@adriencaccia
Copy link
Contributor Author

@adriencaccia Great thanks for this improvement!

We'll be happy to take it, still, it seems to require an update in tests (I believe it's due to changes to generated result) - see CI fail

I fixed the failing test 🙂

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adriencaccia !

@doodlemoonch
Copy link

Thanks @adriencaccia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants