fix(Templates): Add esbuild to gitignore in aws-nodejs-typescript
#10076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10076 +/- ##
=======================================
Coverage 85.41% 85.41%
=======================================
Files 333 333
Lines 13537 13537
=======================================
Hits 11562 11562
Misses 1975 1975 Continue to review full report at Codecov.
|
pgrzesik
approved these changes
Oct 11, 2021
pgrzesik
changed the title
esbuild to gitignore in aws-nodejs-typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
aws-nodejs-typescripttemplate, thanks to #9962, lambda is packaged by esbuild instead of webpack.Now,
.esbuilddirectory is managed by git because.gitignoredoesn't contain it.This PR fixes gitignore to ignore
.esbuildinstead of.webpack.