Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bring back _.flatMap usage #10004

Merged
merged 1 commit into from Sep 24, 2021
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 24, 2021

Reverts #9948 (it covered a bit more originally but other methods were refactored in a meantime)

There was no intention (yet) to get rid of _.flatMap in scope of #7747, as reliable alternative in form of [].flatMap doesn't work with Node.js v10

PR proposed to refactor it into less readable [].reduce logic, which I think reduced readability of logic.

We should keep _.flatMap and refactor it into native [].flatMap on the grounds of v3 (which will come with dropped support for Node.js v10)

/cc @JonasMatos0 @pgrzesik

@medikoo medikoo self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #10004 (711484d) into master (40cdb4f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10004      +/-   ##
==========================================
- Coverage   86.17%   86.17%   -0.01%     
==========================================
  Files         330      330              
  Lines       13161    13160       -1     
==========================================
- Hits        11342    11341       -1     
  Misses       1819     1819              
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 68.81% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cdb4f...711484d. Read the comment docs.

@medikoo medikoo merged commit 0199b0f into master Sep 24, 2021
@medikoo medikoo deleted the 0924-revert-flat-map-removal branch September 24, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant