fix(AWS EventBridge): Ensure proper support for deadLetterConfig

[pgrzesik]

Fixes issue reported here: #9903 (comment)

I've also simplified the setting to avoid using nested arn or targetArn property as the deadLetterConfig has only single arn property. @medikoo Please let me know what do you think about it - do you think it's worth to still keep that nested?

Additionally, I've spotted and fixed a bug with setting the target config when more properties are involved.

I've manually tested it and it seems to work correctly 👍

[codecov]

Codecov Report

Merging #10030 (58d020b) into master (abbb18d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #10030      +/-   ##
==========================================
- Coverage   85.89%   85.88%   -0.01%     
==========================================
  Files         333      333              
  Lines       13419    13416       -3     
==========================================
- Hits        11526    11523       -3     
  Misses       1893     1893              

Impacted Files	Coverage Δ
...ns/aws/package/compile/events/eventBridge/index.js	98.34% <100.00%> (-0.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbb18d...58d020b. Read the comment docs.

[medikoo]

I've also simplified the setting to avoid using nested arn or targetArn property as the deadLetterConfig has only single arn property

Makes sense to me. I wonder that maybe we can improve this property name to deadLetterQueueArn. WDYT?

[pgrzesik]

Sounds great to me @medikoo 👍

[medikoo]

Looks great 👍